4481 Print Individual Donation Receipts #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielf
previously requested changes
Jun 29, 2024
There was a problem hiding this comment.
This works well from a functional pov -- just one thing I'd like to see different functionally . Can we tweak it to include $0.00 for the Money raised if there wasn't any money raised? Why? Having a value there means it can't be as easily altered to show a false value.
I'd also like to see tests confirming that the print buttons show up
|
Added zero dollar money raised display and tests.
|
dorner
requested changes
Jul 4, 2024
|
Latest changes pushed. |
dorner
requested changes
Jul 11, 2024
|
All things being tested for now have hardcoded values. |
dorner
approved these changes
Jul 19, 2024
|
Thanks very much! |
|
@mdphillips375: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4481
Description
Added buttons to donation list rows and donation view page to print PDF receipt of individual donation. PDF is modification of existing distribution receipt.
Type of change
How Has This Been Tested?
Added and modified sample donation records to provide a variety of types of donations: sources, various states of completeness of contact info, line items, money values.
For some reason rSpec is currently getting hung on my system, so these tests were not run. Only changes made to existing code was adding 2 routes, 2 buttons, and one controller method.
Screenshots
Hiding value columns:
Not hiding value columns: